overdue-scratch

Author Topic: [PATCH] restart fix Removed !  (Read 18107 times)

0 Members and 1 Guest are viewing this topic.

cosmo1t

  • VoodooLabs
  • Posts: 25
Re: [PATCH] restart fix Removed !
« Reply #15 on: August 13, 2011, 11:43:18 PM »
hey please post a diff with an issue or a request for merge on forge.voodooprojects.org
we will then work w/ it to get it in the trunk

I'd love to have more features and fixes, but we need to establish a baseline of how this is done.

Thanks slice
cos

Slice

  • VoodooLabs
  • Posts: 52
Re: [PATCH] restart fix Removed !
« Reply #16 on: August 16, 2011, 03:57:10 PM »
hey please post a diff with an issue or a request for merge on forge.voodooprojects.org
we will then work w/ it to get it in the trunk

I'd love to have more features and fixes, but we need to establish a baseline of how this is done.

Thanks slice
cos
3 weeks passed since my post. The patch is still not in trunk? Is it very hard for voodoo team?
I show you all that you need. If you want there is the diff file but I think it is not more easy to apply.

meklort

  • VoodooLabs
  • Posts: 65
Re: [PATCH] restart fix Removed !
« Reply #17 on: August 16, 2011, 04:19:44 PM »
Slice, Please send  a diff that will
1) compile with trunk (eg: Platform is a struct pointer in your branch, while just a struct in trunk).
2) submit the patch on forge.voodooprojects.org
3) *always* verify that the return value is *non null* for getStringForKey before you use it.
4) Verify the complete string, not just the first letter.
5) Values such as 0x756E6547 should be replaced with the corresponding #define

Also, when possible, submit separate patches for separate features.
return c ? c : !c;

Slice

  • VoodooLabs
  • Posts: 52
Re: [PATCH] restart fix Removed !
« Reply #18 on: August 17, 2011, 08:09:59 AM »
Apply my diff and then correct all what you want. I think you are able to do this.
4) I don't know how.

PolishOX

  • Observer
  • Posts: 12
Re: [PATCH] restart fix Removed !
« Reply #19 on: August 18, 2011, 05:08:46 PM »
Apply my diff and then correct all what you want. I think you are able to do this.
4) I don't know how.
Slice as a developer with access to the trunk you do not find writing proper code to be important?

You need some employees or intern to fix your code?