Author Topic: [Implemented] GUI extra graphics for selected device  (Read 102688 times)

0 Members and 1 Guest are viewing this topic.

valv

  • VoodooLabs
  • Posts: 72
    • The AnVAL Forum (fr)
Re: GUI extra graphics for selected device
« Reply #60 on: July 20, 2010, 02:53:43 PM »
Nicely done.
But I have just added this mod to the source code from valv's branch on the SVN and it works fine.
I think it's time to include your great effort into my next release.

smith@@

  • Member
  • Posts: 49
Re: GUI extra graphics for selected device
« Reply #61 on: July 20, 2010, 11:17:26 PM »
There's no introduction needed for this one.. :)
I have revised it slightly by using the rollover images to show a larger version of the device icon to indicate it's selected.



Note: Like the other theme's I have posted here, this uses a blank device_selection graphic so it won't work correctly on a standard Chameleon build, only on a modified Chameleon. However, the device_selection graphic can still be used if required.

Beautiful. I love yours theme  :-[

Azimutz

  • VoodooLabs
  • Posts: 420
  • Paranoid Android
Re: GUI extra graphics for selected device
« Reply #62 on: July 20, 2010, 11:57:39 PM »
Blackosx,
Theme elements (was looking for that expression)... except for the bootprompt, all changes were made to fit to screen.
Yep, menu and infobox were a bit out of screen, but still visible; check the theme.plist attached for the diffs. I guessed you'd be interested on this type of info :) if you need i can take some pics, they wont be great (crappy mobile phone cam) but it's enough for the purpose.
The ReadMe is fine; it's simple yet informative; maybe you could add a bit more detail on how the normal themes work versus rollover themes, but that's just me, not a critic.

Default_revisited also tested. The rollover effect works great, in all situations you created so far.
You just missed the last trunk updates; some of the Default theme png's were updated (r184).

One thing i've been to ask... what about embedding theme? :)

p.s.: hum... new max size for stage2.



valv,
just keep in mind that after adding this, embedding themes wont work.
Don't really know if anyone still cares about that? i know i don't :)



smith@@,
no problemo  8)
« Last Edit: July 21, 2010, 12:17:10 AM by Azimutz »
 System & Patches: http://goo.gl/i961
 Chameleon:
- trunk builds: http://goo.gl/9G1Hq
- pref pane: http://goo.gl/OL2UT

Blackosx

  • Forum Moderator
  • Posts: 1150
Re: GUI extra graphics for selected device
« Reply #63 on: July 21, 2010, 08:20:17 AM »
I think it's time to include your great effort into my next release.
Thanks for you interest valv. Feel free to add what I currently have though it you want to have the capability of embedded themes then see below.

Beautiful. I love yours theme  :-[
Thanks for your feedback smith@@ as I wasn't too sure if I preferred this version as I still like the original?

One thing i've been to ask... what about embedding theme? :)
p.s.: hum... new max size for stage2.

valv,
just keep in mind that after adding this, embedding themes wont work.
Don't really know if anyone still cares about that? i know i don't :)

Well pointed out Azimuth and it's true, as the code in my branch currently stands, embedded themes can't be used (unless of course tiny, low byte count, graphic files are used). However, as you have noticed, Zef has increased the file size limit for the stage 2 booter and has been beavering away in the background making numerous changes/fixes/updates to the code. Of these changes, he's figured out a way to allow the embedding of standard themes whilst still having functionality to load external themes with the rollover functionality. The code isn't finished yet and will be available very soon after testing etc.

Thanks for your feedback again, as yes, I did forget to include the default .png update. ;)

As for resizing/repositioning the themes I'm not sure what I can do with regard to helping them fit all screen sizes/ratios, other than trying to keep the elements away from the edges of the screen. But that does limit the design choices?  I should be able to mimic the effects you see here in a VM, but I think unfortunately, there will always be a bit of re-jigging required to make them fit perfectly on each variation of screen sizes.
10.10.5 / 10.11 GM1 | Asus Maximum IV Gene-Z | i7-2600 3.40GHz | 4GB | Radeon 5770 1GB

Azimutz

  • VoodooLabs
  • Posts: 420
  • Paranoid Android
Re: GUI extra graphics for selected device
« Reply #64 on: July 21, 2010, 09:45:26 AM »
Blackosx;
mystery solved  :) didn't asked sooner for the theme embedding, because i had the feeling you confirmed.
I'm watching the action on the trunk...

If you say you forgot the updated png's, i believe!  ;D i did forgot on the binaries i have on my sig.

Well, just provide that image i mentioned with theme elements positioning and it's done!
The rest it's up to the user; you've made it already too simple for us to tweak themes, with all the work on the forum.
 System & Patches: http://goo.gl/i961
 Chameleon:
- trunk builds: http://goo.gl/9G1Hq
- pref pane: http://goo.gl/OL2UT

zef

  • Administrator
  • Posts: 265
Re: GUI extra graphics for selected device
« Reply #65 on: July 22, 2010, 02:09:21 AM »
just keep in mind that after adding this, embedding themes wont work.
Don't really know if anyone still cares about that? i know i don't :)

I'm (still) working on it :)
ASUS P8Z68-V PRO/GEN3 | i5-2500k | 16GB RAM | GTX560 | Keyboard | Mouse | Devilsound DAC

Azimutz

  • VoodooLabs
  • Posts: 420
  • Paranoid Android
Re: GUI extra graphics for selected device
« Reply #66 on: July 22, 2010, 03:41:50 AM »
yeah, i see your busy Zef :) and keeping me busy ;D nice...
 System & Patches: http://goo.gl/i961
 Chameleon:
- trunk builds: http://goo.gl/9G1Hq
- pref pane: http://goo.gl/OL2UT

Blackosx

  • Forum Moderator
  • Posts: 1150
Re: GUI extra graphics for selected device
« Reply #67 on: July 23, 2010, 11:27:42 PM »
I've managed to create a version of this modifcation with embedded themes working.
• It can boot the embedded theme if there is no theme defined in the com.apple.Boot.plist
• It can boot using a standard RC4 theme
• It can boot using a new rollover theme.

It's built on r204 but I have a problem committing it to my branch, versions gives me the following error:
Code: [Select]
Commit failed (details follow):
Directory '/Users/blackosx/blackosx/artwork/themes/default/.svn' containing working copy admin area is missing
Zef can you help?

I've attached the compiled binary for testing :)
Note: You will have to use the new boot0 and boot1 also to make use of the extended file size.
« Last Edit: July 24, 2010, 12:14:06 AM by Blackosx »
10.10.5 / 10.11 GM1 | Asus Maximum IV Gene-Z | i7-2600 3.40GHz | 4GB | Radeon 5770 1GB

Blackosx

  • Forum Moderator
  • Posts: 1150
Re: GUI extra graphics for selected device
« Reply #68 on: July 24, 2010, 10:26:24 AM »
Now updated using the r214.
Here's the latest binary.
10.10.5 / 10.11 GM1 | Asus Maximum IV Gene-Z | i7-2600 3.40GHz | 4GB | Radeon 5770 1GB

Blackosx

  • Forum Moderator
  • Posts: 1150
Re: GUI extra graphics for selected device
« Reply #69 on: July 24, 2010, 09:09:26 PM »
I have finally managed to commit to my branch. :)
Thanks Zef
10.10.5 / 10.11 GM1 | Asus Maximum IV Gene-Z | i7-2600 3.40GHz | 4GB | Radeon 5770 1GB

Azimutz

  • VoodooLabs
  • Posts: 420
  • Paranoid Android
Re: GUI extra graphics for selected device
« Reply #70 on: July 25, 2010, 12:18:57 AM »
Black, still processing this latest and Zef seems to be playing with it, so comments later...
The compiled booter you posted seems fine but it's ready to explode :D

Did you opted to keep device_fat16 png's as is, on your branch Default theme, or..? they were changed to generic.
If the answer is "or", check also the fat32 ones, they are bigger than the generic_device ones;
you can cut a bit of size there ;)
« Last Edit: July 25, 2010, 05:16:15 AM by Azimutz »
 System & Patches: http://goo.gl/i961
 Chameleon:
- trunk builds: http://goo.gl/9G1Hq
- pref pane: http://goo.gl/OL2UT

zef

  • Administrator
  • Posts: 265
Re: GUI extra graphics for selected device
« Reply #71 on: July 25, 2010, 04:00:17 AM »
Ok guys, can you give a test run with my branch?

http://forge.voodooprojects.org/p/chameleon/source/commit/237/

With meklort's great help we can test for the availability of the embedded images. I don't know how useful is this, but you don't need to embed/load any device icons (except the device_generic and its optional _o counterpart) anymore. The booter can use the generic icon if a theme doesn't have it (like fat16, fat32). To enable the rollover mode, the booter checks for the device_generic and device_generic_o's image pointers and if they're differ then blackosx will be happy :)
« Last Edit: July 25, 2010, 04:30:29 AM by zef »
ASUS P8Z68-V PRO/GEN3 | i5-2500k | 16GB RAM | GTX560 | Keyboard | Mouse | Devilsound DAC

Blackosx

  • Forum Moderator
  • Posts: 1150
Re: GUI extra graphics for selected device
« Reply #72 on: July 25, 2010, 09:46:37 AM »
With meklort's great help we can test for the availability of the embedded images. I don't know how useful is this, but you don't need to embed/load any device icons (except the device_generic and its optional _o counterpart) anymore. The booter can use the generic icon if a theme doesn't have it (like fat16, fat32). To enable the rollover mode, the booter checks for the device_generic and device_generic_o's image pointers and if they're differ then blackosx will be happy :)
Hi Zef

Thanks for the work you have done here.  I have just had a look at the code and downloaded the code from your branch, wow.. it's different!  I am going to have to spend a bit of time reading through it and working out the changes. :)

However, I have just built the code with 'make embedtheme' and done a couple of quick tests and it successfully booted first time a rollover theme, and also a normal RC4 theme.. Brilliant  ;D  Though, how do I get it to use the embedded theme?  as booting without a theme name in the com.apple.Boot.plist, drops me out of the GUI and in to the text loader.

I hope to grab a bit of time later this evening to have a look in to this better, but thank you and Meklort very much for your time and efforts :)
10.10.5 / 10.11 GM1 | Asus Maximum IV Gene-Z | i7-2600 3.40GHz | 4GB | Radeon 5770 1GB

Blackosx

  • Forum Moderator
  • Posts: 1150
Re: GUI extra graphics for selected device
« Reply #73 on: July 25, 2010, 09:52:01 AM »
Black, still processing this latest and Zef seems to be playing with it, so comments later...
The compiled booter you posted seems fine but it's ready to explode :D

Did you opted to keep device_fat16 png's as is, on your branch Default theme, or..? they were changed to generic.
If the answer is "or", check also the fat32 ones, they are bigger than the generic_device ones;
you can cut a bit of size there ;)
Hi Azimuth, yeah my attempt at embedding the themes worked but as you noticed made it very large.. So Zef and Meklort have kindly devoted some of their time to proving a proper solution to this.

But on my branch I changed the default theme icons to have a lower files size so i could fit them inside an embedded theme build, but it looks like I don't have to now with the work being done by Zef & meklort. But thanks for the tip :)
10.10.5 / 10.11 GM1 | Asus Maximum IV Gene-Z | i7-2600 3.40GHz | 4GB | Radeon 5770 1GB

Azimutz

  • VoodooLabs
  • Posts: 420
  • Paranoid Android
Re: GUI extra graphics for selected device
« Reply #74 on: July 25, 2010, 10:15:30 AM »
Zef,

rev 237 passed tests with distinction!  :) everything tested from loading just embedded theme (no Themes folder) to setting diff themes on Boot.plist theme embedded or not... think i didn't missed nothing but, a second opinion is always advised.
Size of embedtheme builds on my working copy of the trunk:
- "default" theme: 356k
- "default revisited" theme, with images from Blackosx branch: 446
- "default" theme with only device_generic: 279  ;D
 This last is as good idea as Blackosx's rollover idea.. not needed but, adds more options and the savings on space may come in handy for some situation; keep it. You can take at least 10k from the numbers above, AutoResolution patch i use takes that +-.

Did a quick test on the changes made by Meklort, breaks on rev 239; theme built with theme embedtheme and no themes folder on booter volume, doesn't load embedded theme.
Nice work, you both!



Hi Blackosx,

yeah, i noticed you tweaked the images on Default Revisited.. it's really the only way to embed a rollover theme. Check the size i got above for Default Revisited with your reduced size images corrected like i told you on my last post.
Anyway, that's all history :)
« Last Edit: July 26, 2010, 03:11:51 AM by Azimutz »
 System & Patches: http://goo.gl/i961
 Chameleon:
- trunk builds: http://goo.gl/9G1Hq
- pref pane: http://goo.gl/OL2UT