Author Topic: [PATCH] Proper Haiku Detection with Custom Icons  (Read 4182 times)

0 Members and 1 Guest are viewing this topic.

scorpius

  • Observer
  • Posts: 22
[PATCH] Proper Haiku Detection with Custom Icons
« on: April 19, 2011, 07:16:42 PM »
Hi, I'm new here and this is my 1st post.

I often use Haiku and thought I'd make it work better with Chameleon.
I included a patch for RC5 r773 (a patch for RC4 is also available).

Update: For consistency, the icon has been matched to the same color as the default theme.
And a typo reported by oldnapalm has been fixed.

« Last Edit: May 21, 2011, 11:30:28 PM by scorpius »

ErmaC

  • Resident
  • Posts: 134
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #1 on: April 29, 2011, 02:22:56 AM »
THX! scorpius

Fabio
P6T Deluxe v1 i7 940 Quadro Fx 5600
P6T SE i7 920 GeForce GT 240

kyndder

  • Entrant
  • Posts: 6
  • To Live is To Die
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #2 on: May 16, 2011, 06:11:44 PM »
Great work scorpius!!!!!

Thanks a lot!!!!!!
MB:DG31PR / CPU:Quad Core Q6600 / RAM:4Gb DDR2 800 / Seventeam 500W / HD1:500Gb Samsung SATA II/ HD2: 250Gb Samsung SATA II/ HD3:1500Gb Samsung SATA II/ DRIVE: DVD-RW LG SATA / KB-Mouse Microsoft Wireless / LG W2284F 22" / GeForce 9600 GSO / Leopard 10.5.8 / Snow Leopard 10.6.6 x64 / Ubuntu 10.10 x64 / Wndows 7 / Haiku-OS (BeOS) / Chameleon 2 RC5

scorpius

  • Observer
  • Posts: 22
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #3 on: May 18, 2011, 11:43:42 PM »
Now all I have to do is change the blue color to brown. Also, if your video card doesn't have a vesa resolution that matches your monitor's native resolution, check out my 'unstretch chameleon' topic. It's the only way I can get a clear screen with Haiku.   

oldnapalm

  • Member
  • Posts: 45
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #4 on: May 19, 2011, 06:19:03 AM »
I think it should be
Code: [Select]
LOADPNG(device_befs,                    iDeviceGeneric);
LOADPNG(device_befs_o,                  iDeviceBEFS);
instead of
Code: [Select]
LOADPNG(device_befs,                    iDeviceBEFS);
LOADPNG(device_befs_o,                  iDeviceBEFS_o);
or GUI won't start if there's no device_befs.png in theme folder.

Second argument for LOADPNG is alt_img (alternative image I guess)
Code: [Select]
#define LOADPNG(img, alt_img) if (loadThemeImage(#img, alt_img) != 0) { return 1; }

scorpius

  • Observer
  • Posts: 22
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #5 on: May 20, 2011, 10:43:07 PM »
You are correct, sir. Thanks for finding that mistake in the code.

ErmaC

  • Resident
  • Posts: 134
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #6 on: August 20, 2011, 02:36:25 AM »
Thx scorpius!

you work as been merged to main chameleon trunk r1440

Fabio
P6T Deluxe v1 i7 940 Quadro Fx 5600
P6T SE i7 920 GeForce GT 240

scorpius

  • Observer
  • Posts: 22
Re: [PATCH] Proper Haiku Detection with Custom Icons
« Reply #7 on: August 20, 2011, 05:12:25 PM »
I never imagined that it would get merged into the official code. I'm happy!  :)