overdue-scratch

Author Topic: boot hang with r631 due to call to DT__AddProperty  (Read 1296 times)

0 Members and 1 Guest are viewing this topic.

lnxneo

  • Entrant
  • Posts: 2
boot hang with r631 due to call to DT__AddProperty
« on: November 07, 2010, 02:27:04 PM »
Hi developers,

The latest chameleon (r631) added a lot great features, such as P/C state generation, thus I decided to try it out. However, it cause hang on my computer. So I checked it code and found some potential issues:

When calling "DT__AddProperty", the data stored in the address that argument "value" point to shall remain unchanged utill "DT__FlattenDeviceTree" is call.
However, in "acpc_patcher.c", the caller to addConfigurationTable (then call DT__AddProperty), at line 716,717,1066,1072, using address of local variables, which are on the stack, when those functions finish, the data in those address will be trashed, thus cause the problem. What do you think?
 
Best regards,

-Lnxneo

valv

  • VoodooLabs
  • Posts: 72
    • The AnVAL Forum (fr)
Re: boot hang with r631 due to call to DT__AddProperty
« Reply #1 on: November 07, 2010, 11:59:24 PM »
r631 is from meklort's branch, which is different from the trunk in many aspects. You need to get your self a trunk revision, else u have to follow the one specific branch instructions.