Voodooprojects

Chameleon => DevTalk => Patches => Topic started by: scorpius on April 19, 2011, 07:16:42 PM

Title: [PATCH] Proper Haiku Detection with Custom Icons
Post by: scorpius on April 19, 2011, 07:16:42 PM
Hi, I'm new here and this is my 1st post.

I often use Haiku and thought I'd make it work better with Chameleon.
I included a patch for RC5 r773 (a patch for RC4 is also available).

Update: For consistency, the icon has been matched to the same color as the default theme.
And a typo reported by oldnapalm has been fixed.

(http://gamma-ray.home.comcast.net/img/Chameleon-Haiku.png)
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: ErmaC on April 29, 2011, 02:22:56 AM
THX! scorpius

Fabio
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: kyndder on May 16, 2011, 06:11:44 PM
Great work scorpius!!!!!

Thanks a lot!!!!!!
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: scorpius on May 18, 2011, 11:43:42 PM
Now all I have to do is change the blue color to brown. Also, if your video card doesn't have a vesa resolution that matches your monitor's native resolution, check out my 'unstretch chameleon' topic. It's the only way I can get a clear screen with Haiku.   
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: oldnapalm on May 19, 2011, 06:19:03 AM
I think it should be
Code: [Select]
LOADPNG(device_befs,                    iDeviceGeneric);
LOADPNG(device_befs_o,                  iDeviceBEFS);
instead of
Code: [Select]
LOADPNG(device_befs,                    iDeviceBEFS);
LOADPNG(device_befs_o,                  iDeviceBEFS_o);
or GUI won't start if there's no device_befs.png in theme folder.

Second argument for LOADPNG is alt_img (alternative image I guess)
Code: [Select]
#define LOADPNG(img, alt_img) if (loadThemeImage(#img, alt_img) != 0) { return 1; }
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: scorpius on May 20, 2011, 10:43:07 PM
You are correct, sir. Thanks for finding that mistake in the code.
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: ErmaC on August 20, 2011, 02:36:25 AM
Thx scorpius!

you work as been merged to main chameleon trunk r1440

Fabio
Title: Re: [PATCH] Proper Haiku Detection with Custom Icons
Post by: scorpius on August 20, 2011, 05:12:25 PM
I never imagined that it would get merged into the official code. I'm happy!  :)