Author Topic: Invalid package length algorithm in aml_generator.c  (Read 972 times)

0 Members and 1 Guest are viewing this topic.

rphilipson

  • Entrant
  • Posts: 1
Invalid package length algorithm in aml_generator.c
« on: January 20, 2012, 08:31:55 PM »
I believe the code to calculate the package length values is incorrect in aml_generator.c - specifically in the functions:
aml_write_size and aml_get_size_length. The issue is that the values at which an extra byte is determined to be needed are incorrect.

Within the Intel ASL compiler sources you can see the correct algorithm in: compiler/asllength.c

I am also attaching what I believe is fixed code in a C file.

Slice

  • VoodooLabs
  • Posts: 52
Re: Invalid package length algorithm in aml_generator.c
« Reply #1 on: May 23, 2012, 10:28:50 AM »
You are right.
Thank you, will implement the patch.